On 2025/05/22 8:58, Tom Lane wrote:
Michael Paquier <mich...@paquier.xyz> writes:
On Wed, May 21, 2025 at 09:24:26AM +0200, Daniel Gustafsson wrote:
Agreed, and +1 on the change in general.

Another point perhaps worth considering after a second look: how about
pg_ci_base.conf?  We have the following line there, exposing this
configuration with TEMP_CONFIG:
src/tools/ci/pg_ci_base.conf:log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] '

The two other ones are:
src/test/perl/PostgreSQL/Test/Cluster.pm: '%m [%p] %q%a '
src/test/regress/pg_regress.c: '%m %b[%p] %q%a '

Perhaps it would be better to apply the same configuration as the CI
by default at the end?

I'd vote for standardizing on pg_regress.c's spelling, as that's got
the most usage history behind it.  I'm unexcited about bloating the
logs with [%v:%x] --- that's data I've very seldom needed.

+1

Regards,

--
Fujii Masao
NTT DATA Japan Corporation



Reply via email to