On Sat, May 24, 2025 at 09:09:36AM +0900, Michael Paquier wrote: > On Fri, May 23, 2025 at 11:56:59PM +0900, Fujii Masao wrote: >> On 2025/05/22 8:58, Tom Lane wrote: >>> I'd vote for standardizing on pg_regress.c's spelling, as that's got >>> the most usage history behind it. I'm unexcited about bloating the >>> logs with [%v:%x] --- that's data I've very seldom needed. >> >> +1
Coming back to this thread as v19 is going to open up rather soon, the suggestion from Tom seems to be the consensus reached, which is to use the same value of log_line_prefix in the CI and the TAP as in pg_regress.c. Attached is a patch to do so, that I'd like to apply on HEAD once v19 opens up. If anybody would prefer a backpatch or if anybody has any comments, please feel free. -- Michael
diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm index 1c11750ac1d0..49b2c86b29cb 100644 --- a/src/test/perl/PostgreSQL/Test/Cluster.pm +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm @@ -684,7 +684,7 @@ sub init print $conf "\n# Added by PostgreSQL::Test::Cluster.pm\n"; print $conf "fsync = off\n"; print $conf "restart_after_crash = off\n"; - print $conf "log_line_prefix = '%m [%p] %q%a '\n"; + print $conf "log_line_prefix = '%m %b[%p] %q%a '\n"; print $conf "log_statement = all\n"; print $conf "log_replication_commands = on\n"; print $conf "wal_retrieve_retry_interval = '500ms'\n"; diff --git a/src/tools/ci/pg_ci_base.conf b/src/tools/ci/pg_ci_base.conf index 9cec5c2910d8..695e0a0d6ec9 100644 --- a/src/tools/ci/pg_ci_base.conf +++ b/src/tools/ci/pg_ci_base.conf @@ -10,5 +10,5 @@ log_autovacuum_min_duration = 0 log_checkpoints = true log_connections = all log_disconnections = true -log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] ' +log_line_prefix = '%m %b[%p] %q%a ' log_lock_waits = true
signature.asc
Description: PGP signature
