On Wed, Jun 4, 2025 at 10:46 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Sun, Jun 1, 2025 at 10:25 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > Yet another idea is to dump the subscription with two_phase = on and > > failover = false. We should do this when both options are 'true' > > during the dump. As we are documenting that we always dump > > createsubscription with connect as false and let users take care (see > > [1] (When dumping logical replication subscriptions ...)), a similar > > reasoning could be given for the failover flag. > > It probably would work for subscriptions but what about logical slots? > If we restore two_phase=on and failover=false, the user would have to > enable the failover via ALTER_REPLICATION_SLOT. I think we should > avoid asking users to execute the replication commands directly. >
Sorry, I mixed manually creating a logical slot and restoring a dump, and I think we've already discussed that. Please ignore this comment. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
