On Thu, Jun 5, 2025 at 2:53 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > On Tue, Jun 3, 2025 at 11:05 AM Nisha Moond <nisha.moond...@gmail.com> wrote: > > > > > > Attached v17 patches. Added a top-up patch 0002 implementing the idea > > suggested by Amit above. > > I have started reviewing this, although I haven't done a complete > review yet, but I have a question on the fix we are trying to do, IIUC > we are disallowing to use 'two phase' and 'failover' options together > at the create slot time and now users has to create slot with one of > the option and later enable other option right (if user want to use > both options)? But don't you think it will affect usability? because > if a user wants to use both the options together then after creating > the slot they need to track when is the right time to enable the other > option? >
Note that this is the restriction for 17 only, as we can't think of a better way to fix it. For HEAD, we have exposed two_phase_at via the existing view to fix this bug, see 4868c96bc8. We can't do the same in backbranches as discussed in email [1]. If you have any better ideas to fix this in backbranch, then kindly let us know. [1] - https://www.postgresql.org/message-id/CAA4eK1Jx7Ed_58%2BywXozmHvRRhAVO2Yfcyoi0e5PRexZn5A6Gw%40mail.gmail.com -- With Regards, Amit Kapila.
