On Fri, Jun 6, 2025 at 5:07 PM Nisha Moond <nisha.moond...@gmail.com> wrote: > > > Attached v18 patch. > - patch-001: modified error messages as suggested above. > - patch-002: improved pg_dump docs as per Shveta's off-list suggestions. > > [1] > https://www.postgresql.org/message-id/CAA4eK1%2BB067G8mUJzKUEjc5KSkYq6z0utTaHey-qeRt%2BnZTNJg%40mail.gmail.com > > -- > Thanks, > Nisha
Hi Nisha, Some comments. Patch 0001 1. Commit message from "two_phase enables slots." to "two_phase enabled slots" 2. + + <para> + When a subscription's + <link linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link> + is in the pending state, setting <literal>failover</literal> to true is not + permitted. Once The term "subscription's two_phase" sounds a bit vague here. Referring https://www.postgresql.org/docs/17/sql-createsubscription.html and https://www.postgresql.org/docs/current/catalog-pg-subscription.html two_phase is referred to both as the "internal state" as well as the "mode" of the subscription. Probably rephrase it to - "When a subscription's internal two_phase mode is in the pending state, setting failover to true is not permitted. See column subtwophasestate of pg_subscription to know the actual internal state of the two-phase mode" (with appropriate tags and reference links) Patch 0002 1. Commit message Typo: change "subscrption" to "subscription" regards, Ajin Cherian Fujitsu Australia
