> On 5 Jun 2025, at 13:14, Peter Eisentraut <pe...@eisentraut.org> wrote:
> 
> On 07.04.25 02:55, Daniel Gustafsson wrote:
>>> On 7 Apr 2025, at 02:43, David G. Johnston <david.g.johns...@gmail.com> 
>>> wrote:
>>> How about:
>>> 
>>> + "    if set to a number, overrides the default two second \\watch 
>>> interval\n"
>>> 
>>> I do like the consistency of "if set" even though most of the others are 
>>> booleans.
>> Ah yes, number is better. I'll go ahead with that in the morning.
> 
> I came across this psql help text and had a hard time processing it, and, 
> without having read this thread, my thought process was that the message 
> should be phrased more like how it was originally.
> 
> The problem with the current phrasing is:
> 
> - "if set to a number" seems to indicate that something else happens if it's 
> not a number.  But it doesn't say what.  And it's also not true. And we don't 
> phrase things like that for other numeric settings.
> 
> - The way this is phrased now seems to say that the variable is unset by 
> default, and only if it is set does it override the default.  But that is not 
> what happens.  The variable has a value by default, and that is what gets 
> used.
> 
> I suggest something like this:
> 
> number seconds \watch waits between executions (in seconds, default %d)
> 
> 
> While we're here, the documentation could also use some more detail:
> 
>      <varlistentry id="app-psql-variables-watch-interval">
>        <term><varname>WATCH_INTERVAL</varname></term>
>        <listitem>
>        <para>
>        This variable sets the default interval which <command>\watch</command>
>        waits between executing the query.  Specifying an interval in the
>        command overrides this variable.
>        </para>
>        </listitem>
>      </varlistentry>
> 
> This mentions neither the units nor the default value.

How about the attached (reflowing rows in docs not done to keep the diff 
readable)?

--
Daniel Gustafsson

Attachment: helptext_v2.diff
Description: Binary data

Reply via email to