On Wed, Jun 25, 2025 at 11:25 AM Dilip Kumar <dilipbal...@gmail.com> wrote:
> On Wed, Jun 25, 2025 at 1:18 PM Hayato Kuroda (Fujitsu)
> <kuroda.hay...@fujitsu.com> wrote:
> > Another idea is to call ReplicationSlotsComputeRequiredLSN() when at least 
> > one
> > of the restart_lsn is updated, like attached. I feel this could reduce the 
> > computation
> > bit more.
>
> Right, that makes sense, if there is nothing updated on disk then we
> can avoid computing this.

Good idea.  But I think we should associate the "updated" flag
directly to the fact that one slot (no matter logical or physical)
changed its last_saved_restart_lsn.  See the attached patch.  I'm
going to push it if no objections.

------
Regards,
Alexander Korotkov
Supabase

Attachment: v1-0001-Fix-CheckPointReplicationSlots-with-max_replicati.patch
Description: Binary data

Reply via email to