Dear Alexander, > Regarding last_saved_restart_lsn_updated, I think the opposite. I > think we should check if last_saved_restart_lsn_updated is set already > only if it could promise us some economy of resources. In our case > the main check only compares two fields of slot. And that fields are > to be accessed anyway. So, we are not going to save any RAM accesses. > Therefore, checking for last_saved_restart_lsn_updated seems like > unnecessary code complication (and I don't see we're doing that in > other places). So, I'm going to push this patch "as is".
To clarify: I have no objections. Thanks for giving the knowledge. Best regards, Hayato Kuroda FUJITSU LIMITED