On 2025-Jul-05, Masahiko Sawada wrote: > On Fri, Jul 4, 2025 at 8:01 PM Álvaro Herrera <alvhe...@kurilemu.de> wrote: > > > > On 2025-Jul-04, Japin Li wrote: > > > > > I've opted to directly use %X/%08X for LSN formatting in this patch, with > > > an > > > accompanying comment near LSN_FORMAT_ARGS. > > > > Thank you! I support this approach and intend to work on getting this > > patch committed soon after some more review, unless there are further > > objections. > > +1. I think we need to update LSN values in the documentation too.
You're right, we had a few of those. I grepped for them and adjusted what I found. I could have missed some, because there's a bunch of other values that also look like slash-separated hexadecimal numbers. The only case where I did something other than adding a leading zero was the example output for gist_page_opaque_info() because I wasn't sure that the 'nsn' column was also going to be printed as an LSN :-) so I just ran the example query using one index from the regression database. And pushed. Thanks! -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "No tengo por qué estar de acuerdo con lo que pienso" (Carlos Caszeli)
