On Fri, Oct 10, 2025 at 3:04 AM Álvaro Herrera <[email protected]> wrote: > > On 2025-Oct-10, jian he wrote: > > > On Fri, Oct 10, 2025 at 6:03 AM Masahiko Sawada <[email protected]> > > wrote: > > > > Yes, but I think it's more consistent given that we use the > > > parentheses in all other places in copyto.c. > > > > If you look at tablecmds.c, like ATExecSetNotNull, there are > > parentheses and no parentheses cases. > > Overall, I think less parentheses improves readability and makes the > > code more future-proof. > > I strive to remove those extra parentheses when I edit some part of the > code (though I may forget at times), but leave them alone from other > places that I'm not editing. I don't add them in new code. Most > likely, this is why ATExecSetNotNull has some cases with them and other > cases without. > > Given sufficient time, the Postgres of Theseus would eventually have > zero of those extra parens.
Thank you for the input. I didn't know some files or functions already have mixed style. I'll use this style for future changes. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
