Hi Tom, > Maybe I shouldn't put words in Álvaro's mouth, but I think the reason > you're getting so much pushback from senior hackers is that we > remember some very bad experiences with automated #include-removal > years ago --- particularly 1609797c2, which turned me for one off the > idea altogether. The currently available tools are probably smarter > than what we were using back then, but they're evidently still not > perfect, and we're leery of having to undo work. > > I think the issues you're hitting right now may stem from not > compiling with all available options. Notably, if you don't have > --enable-cassert turned on, there's a pretty fair amount of code > you might be failing to account for.
I did test --enable-cassert and some other options I typically enable, but I definitely didn't test all of them. cfbot is happy with the patch right now but given the controversy around it I guess we better invest our time into something else. Withdrawn. -- Best regards, Aleksander Alekseev
