Hi Álvaro, > I wonder how many of these changes pass the compilation only because the > header you're removing is indirectly being included via another header. > In this particular case, it's because slot.h includes walreceiver.h > which includes walsender.h, so this removal has no effect.
Hm.... on the flip side if the file is already included what's the point in the second #include? It doesn't do anything and is redundant, isn't it? At least my text editor highlights it as such (because clangd tells it so). This is not a huge problem of course, just a bit distracting. If the idea is to always have an explicit list of all the includes (no indirect ones) I think we may end up with pretty long lists, and I don't instantly see value in this to be honest. -- Best regards, Aleksander Alekseev
