On Tue, Oct 21, 2025 at 11:52 PM Xuneng Zhou <[email protected]> wrote: > The patch LGTM.
Thanks for the review! I've pushed the patch and backpatched it to all supported versions. > I am wondering whether it is helpful to add some > comments for this overflowed array Yes, do you have any specific suggestions? > and replacing literal zeros with the constant InvalidXLogRecPtr for > better readability. > > /* InvalidXLogRecPtr means no overflow yet */ > if (lag_tracker->overflowed[i].lsn == InvalidXLogRecPtr) I couldn't find any code like "lag_tracker->overflowed[i].lsn == 0", so I'm not sure which part should be replaced with InvalidXLogRecPtr. Could you point me to the exact location? Regards, -- Fujii Masao
