On Thu, Nov 13, 2025 at 9:58 AM Fujii Masao <[email protected]> wrote:
> On Wed, Nov 12, 2025 at 10:23 PM Sugamoto Shinya <[email protected]> > wrote: > > Thanks everyone for reviewing my proposal. > > I've hard-coded the valid list of encoding names. > > > > Also, I modified the hint string into like "Valid encodings are \"hex\", > \"base64\", \"base64url\", and \"escape\"." > > by adding "and" before "escape". > > > > I attached my v2 patch to this message. Please let me know freely if you > have any additional questions. > > Thanks for the updated patch! LGTM. > > One minor comment: in v2 patch, it seems the encodings in the HINT message > are > listed in the order they appear in the enclist struct. Wouldn't it be > clearer to list them > alphabetically, matching the order shown in the docs [1]: base64, > base64url, escape, and hex? > > Regards, > > [1] > https://www.postgresql.org/docs/devel/functions-binarystring.html#ENCODE-FORMAT-BASE64 > > -- > Fujii Masao > Thanks, Fujii and Peter. I ordered the valid encodings alphabetically and extracted those into separate parameters. Here is my new patch. Regards,
v3-0001-Add-error-hints-for-invalid-binary-encoding-names.patch
Description: Binary data
