> On 17 Nov 2025, at 15:08, Sugamoto Shinya <[email protected]> wrote:

> I ordered the valid encodings alphabetically and extracted those into 
> separate parameters.

LGTM.  Per project style I don't think we should quote the names of encodings
since they are visibly not English words (see commit a243569bf65c5 which deals
with variable names, but I think it applies here as well), but no need to send
another version of the patch just for that small adjustment.

--
Daniel Gustafsson



Reply via email to