On Thu, 27 Nov 2025 at 11:57, Bertrand Drouvot <[email protected]> wrote: > > Hi hackers, > > PFA patches to remove unused function parameters in contrib (more patches will > come for non contrib). > > The patches are split by modules to ease the review. > > For 0005 (collid not used in internal_citext_pattern_cmp()) I think that the > unused column should be used (as done in 0005) due to an oversight in commit > f2464997644c. > > This has been done with the help of a coccinelle script. It needs more > polishing, > so will share later. > > Regards, > > -- > Bertrand Drouvot > PostgreSQL Contributors Team > RDS Open Source Databases > Amazon Web Services: https://aws.amazon.com
Hi! Regarding 0005. collid arg was not used, and nobody ever compiled, and then we want to make a change in citext_pattern_cmp behaviour. I think we need to at least exercise this code in regression tests. -- Best regards, Kirill Reshke
