On 12/9/2025 3:03 PM, Thomas Munro wrote: > On Sun, Nov 30, 2025 at 1:13 PM Thomas Munro <[email protected]> wrote: >> What do you think about these improvements? See attached. >> >> * moved and adjusted new comment about flag conversion to cover all >> three flags, since it's true for all of them >> * adjusted the comment about why we don't use SetHandleInformation() >> to highlight that it would be (slightly) leaky >> * removed O_DIRECT's extra definition from port.h, since it's now in >> win32_port.h > > Hearing nothing, pushed. > > I realised while back-patching that REL_16_STABLE was the last release > that also had the old Windows-only build/test machinery under > src/tools/msvc. It never ran all the tests anyway, and I don't think > we'd learn anything new by adding it, given that CI uses meson on that > branch, so I didn't worry about remembering how to adjust that for > now. If someone feels strongly about it, of course we can. Well, my drafts folder had nothing but agreement in it...
Thanks, -- Bryan Green EDB: https://www.enterprisedb.com
