Bryan Green <[email protected]> writes:
> I removed the useless snprintf() call that was using GetCommandLine().
> That was left in place when I moved to GetModuleFileName(). Also,
> removed the unused 'space_pos' variable and the unneeded scope block.
All good to my eye.
> I decided to just use 1024 for the exe_path size since that is what
> cmdline is set to use.
Personally I'd have gone the other way, say
char exe_path[MAXPGPATH];
char cmdline[MAXPGPATH + 100];
> I also removed some self-evident comments that
> were leftover from my practice of writing comments and then coding.
I think you went way overboard on removing "self-evident" comments.
Signposts as to what the code intends to do are pretty helpful IMO.
They do have to be accurate though, for instance this previous
comment:
- * Find the actual executable path by removing any arguments from
- * GetCommandLine().
didn't seem to convey what the code was doing (which I neglected
to complain about before).
BTW, pgindent will undo some of the whitespace changes you made
here.
regards, tom lane
