On Thu, Feb 19, 2026 at 5:54 PM Amit Kapila <[email protected]> wrote:
>
> On Thu, Feb 19, 2026 at 4:08 PM Dilip Kumar <[email protected]> wrote:
> >
> > 3. Question, what would be the behavior of
> > pg_get_publication_tables(), if we have created PUBLICATION FOR ALL
> > TABLES with EXCEPT, I assume it will give all table even in the EXCEPT
> > list
> >
>
> No, it won't return the tables mentioned in the except list and I
> think that is what we expect from this function.

Yeah logically that makes sense, I got confused because of the another
function with name 'pg_get_publication_effective_tables'

> > as we have another function to get effective tables i.e.
> > pg_get_publication_effective_tables(),
> >
>
> This function is for a different purpose and I think its name can be
> improved, how about pg_get_publication_partitions() or something on
> those lines?

I think the current name is confusing, not sure about what would be a
better name, IMHO pg_get_publication_partitions() is not confusing at
least.

And also ,regarding the naming of is_relid_excepted() and
is_relid_or_ancestor_excepted(), although they accurately reflect the
EXCEPT keyword, "excepted" feels a bit awkward in code. I'd suggest
changing these to is_relid_excluded() and
is_relid_or_ancestor_excluded() for better readability.  But if others
think excepted also looks fine and it's just me who doesn't like it
then feel free to ignore this suggestion.

-- 
Regards,
Dilip Kumar
Google


Reply via email to