On Wed, Feb 25, 2026 at 10:43 PM Shlok Kyal <[email protected]> wrote: > > I have also split the patch 0002 to 0002 and 0003 > 0001 - Support CREATE PUBLICATION ... EXCEPT TABLE syntax >
Few comments: ============= * * pub_all_obj_type is one of: * - * TABLES + * TABLES [EXCEPT [TABLE] ( table [, ...] )] As per above syntax in gram.y, [TABLE] is optional but won't it be confusing when we also support sequences? Then we need to identify whether the object given in EXCEPT list is table or sequence. So, I think it is better to keep TABLE as non-optional. * Can we have one test related to INHERITS for actual replication unless it is already there? -- With Regards, Amit Kapila.
