On Tue, Mar 3, 2026 at 8:42 AM Chao Li <[email protected]> wrote:
>
>
>
> > On Feb 28, 2026, at 09:21, David G. Johnston <[email protected]> 
> > wrote:
> >
> > On Fri, Feb 27, 2026 at 5:12 PM Chao Li <[email protected]> wrote:
> >
> > PFA v3.

Thanks for updating the patch! LGTM

One more comment: the handling of empty-string comments exists in both
CreateComments() and CreateSharedComments(). For better test coverage,
how about adding also the regression test to check that COMMENT with
empty-string works as expected for shared objects such as roles?

Regards,

-- 
Fujii Masao


Reply via email to