> On Mar 3, 2026, at 13:51, Fujii Masao <[email protected]> wrote:
>
> On Tue, Mar 3, 2026 at 12:17 PM Chao Li <[email protected]> wrote:
>>
>>
>>
>>> On Mar 3, 2026, at 08:28, Fujii Masao <[email protected]> wrote:
>>>
>>> On Tue, Mar 3, 2026 at 8:42 AM Chao Li <[email protected]> wrote:
>>>>
>>>>
>>>>
>>>>> On Feb 28, 2026, at 09:21, David G. Johnston <[email protected]>
>>>>> wrote:
>>>>>
>>>>> On Fri, Feb 27, 2026 at 5:12 PM Chao Li <[email protected]> wrote:
>>>>>
>>>>> PFA v3.
>>>
>>> Thanks for updating the patch! LGTM
>>>
>>> One more comment: the handling of empty-string comments exists in both
>>> CreateComments() and CreateSharedComments(). For better test coverage,
>>> how about adding also the regression test to check that COMMENT with
>>> empty-string works as expected for shared objects such as roles?
>>>
>>
>> Sure. CreateSharedComments() handles database, tablespace and role, so as
>> you suggested, I added tests for role in v4.
>>
>>> From: zhangqiang <[email protected]>
>>>
>>> Hi hackers,I have verified that using an empty string does indeed delete
>>> comments. I agree this patch content enables users to better understand how
>>> the database program handles empty strings when using the COMMENT ON
>>> command in documentation, thereby improving the user experience.I think
>>> it's a good patch.
>>>
>>
>> Thanks for your review. Sounds good.
>>
>> PFA v4:
>> * Add tests that use NULL and ‘’ to remove comments from a role object.
>
> Thanks for updating the patch! I've pushed it.
>
> Regards,
>
>
> --
> Fujii Masao
Hi Fujii-san, thank you very much for pushing.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
