On Fri, Mar 20, 2026 at 10:30 PM Gyan Sreejith <[email protected]> wrote: >
0001: ===== * +static void pg_createsub_log(enum pg_log_level, enum pg_log_part, + const char *pg_restrict fmt,...) + pg_attribute_printf(3, 4); +pg_noreturn static void pg_fatal(const char *pg_restrict fmt,...) + pg_attribute_printf(1, 2); I see similar functions in other modules are named a bit differently. For example, see report_manifest_error(), report_backup_error(), report_fatal_error(). Then I see many other error reporting functions named similarly in code, some examples are: report_invalid_record(), report_invalid_page(), report_namespace_conflict(), and report_recovery_conflict(). Based on the above information, can we consider renaming the above functions to report_createsub_log() and report_createsub_fatal()? Other than the above point, 0001 LGTM. -- With Regards, Amit Kapila.
