On Tue, Sep 25, 2018 at 7:46 AM Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Thomas Munro <thomas.mu...@enterprisedb.com> writes: > > > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > >> Mark G <markg...@gmail.com> writes: > > >>> While looking at some of the recent churn in DSA I noticed that > > >>> dsa_size_class_map should probably be declared const. > > > > >> +1 ... also, given the contents of the array, "char" seems like > > >> rather a misnomer. I'd be happier if it were declared as uint8, say.
Pushed. Thanks both for the code review! -- Thomas Munro http://www.enterprisedb.com