On Tue, Mar 31, 2026 at 8:30 PM vignesh C <[email protected]> wrote:
>
...
>
> Thanks for the comments. This is addressed in the 002 patch attached.
> The 001 patch has the rebased version of the patch at [1] to fix
> Peter's earlier comments at [2].
>
> [1] -
> https://www.postgresql.org/message-id/CALDaNm0mYT55pjdyN-yY%3D5dSOfMVx307CtP3xYqzWVa0MPRtLQ%40mail.gmail.com
> [2] -
> https://www.postgresql.org/message-id/CAHut%2BPvw-XNBnW-ymGdWpLxaEime7_EdOihcUheGyZvw73kcgg%40mail.gmail.com
>
Hi Vignesh.
Thanks for following up on my outstanding review comments.
//////
Patch 0001 - Fix few issues in commit fd366065e0
This did not address the review comment 3a about the redundant macro
'_("\"%s\"")', but that one might be better handled in a separate
thread anyway. I can post a separate thread for that one later.
So, patch 0001 LGTM.
//////
Patch 0002 - Reuse table_object in publication command syntax
LGTM.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
