On Wed, Apr 1, 2026 at 6:13 AM Peter Smith <[email protected]> wrote: > > On Tue, Mar 31, 2026 at 8:30 PM vignesh C <[email protected]> wrote: > > > ... > > > > Thanks for the comments. This is addressed in the 002 patch attached. > > The 001 patch has the rebased version of the patch at [1] to fix > > Peter's earlier comments at [2]. > > > > [1] - > > https://www.postgresql.org/message-id/CALDaNm0mYT55pjdyN-yY%3D5dSOfMVx307CtP3xYqzWVa0MPRtLQ%40mail.gmail.com > > [2] - > > https://www.postgresql.org/message-id/CAHut%2BPvw-XNBnW-ymGdWpLxaEime7_EdOihcUheGyZvw73kcgg%40mail.gmail.com > > > > Hi Vignesh. > > Thanks for following up on my outstanding review comments. > > ////// > Patch 0001 - Fix few issues in commit fd366065e0 > > This did not address the review comment 3a about the redundant macro > '_("\"%s\"")', but that one might be better handled in a separate > thread anyway. I can post a separate thread for that one later. >
Yes, as it uses an existing code as an example, it is better to start a separate thread. I was planning to do some research by myself after finishing the pending tasks here but feel free to start if you have formed your thoughts on it. -- With Regards, Amit Kapila.
