Hi, On 2018/09/17 1:07, Jonathan S. Katz wrote: > On 9/16/18 11:36 AM, Bruce Momjian wrote: >> On Sat, Sep 15, 2018 at 11:06:04AM -0400, Jonathan Katz wrote: >>> @@ -2414,12 +2408,8 @@ same commits as above >>> The option <option>--create-slot</option> creates >>> the named replication slot (<option>--slot</option>) >>> when the <acronym>WAL</acronym> streaming method >>> - (<option>--wal-method=stream</option>) is used. >>> - </para> >>> - >>> - <para> >>> - IS IT CLEAR FROM THE DOCS THAT THE REPLICATION SLOT IS NOT >>> - TEMPORARY? >>> + (<option>--wal-method=stream</option>) is used. The replication >>> slot is >>> + available until it is explicitly dropped. >>> </para> >>> </listitem> >> >> I have clarified the documentation for this option. This additional >> release note text is not necessary. > > Thanks for updating it in the docs. > > I can make arguments both ways about including/not including that in the > release notes, but I've attached a patch that drops the clarification.
Sorry I couldn't reply sooner, but the following of your proposed text needs to be updated a bit: + <listitem> + <para> + Having a "default" partition for storing data that does not match a + partition key + </para> + </listitem> I think "does not match a partition key" is not accurate. Description of default partitions further below in the release notes says this: "The default partition can store rows that don't match any of the other defined partitions, and is searched accordingly." So, we could perhaps write it as: Having a "default" partition for storing data that does not match any of the remaining partitions Thanks, Amit
