On Mon, May 11, 2026 at 12:40:38PM +0700, John Naylor wrote: > On Wed, Apr 15, 2026 at 8:19 AM Bruce Momjian <[email protected]> wrote: > > Hi Bruce, thanks for you work on this. Here are some comments: > > > Allow C++ compiler mode to be used with ICU (John Naylor) § > > That was just for our headerscheck and I'd be surprised if it mattered > for extension authors. Also, a later commit af2d4ca191 got rid of > including ICU headers in our local headers entirely, so that > supersedes the above anyway.
Great, removed. > > Optionally use AVX2 CPU instructions for calculating page checksums > > (Matthew Sterrett, Andrew Kim) § > > > Optionally use ARM Crypto Extension to Compute CRC32C (John Naylor) § > > There's no option for these, the extensions are used where available. So, the "Optionally" indicates we use these instructions if the CPU supports them. I assume we don't use them on all CPUs. Can you suggest better wording? > > Improve sort performance using radix sorts (John Naylor) § > > Minor quibble: I think it's more normal to refer to "sort" as a > non-count noun, when talking about a technique. Done. > > Improve performance of numeric operations on platforms without 128-bit > > integer support (Dean Rasheed) § > > The intent was a more of a simplification/refactoring. Server > platforms without 128-bit integer support are few and far between > (e.g. S390X on some broken versions of clang, which I tested out of > curiosity). Okay, removed. > > Change index access method handlers to use a static IndexAmRoutines > > structure, rather than dynamically allocated ones (Matthias van de Meent) § > > > > This is a backwardly incompatible. > > I understand this whole section to be about incompatibilities -- if > there was a follow-up mention here, it seems to have been lost along > the way. Okay, I have removed "This is a backwardly incompatible.", which I think was your point. -- Bruce Momjian <[email protected]> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
