On Tue, 26 May 2026 at 16:00, Bruce Momjian <[email protected]> wrote: > > On Tue, May 26, 2026 at 01:25:15PM +0800, Chao Li wrote: > > Chong Peng, whom I added to CC, reported this release note issue to me, so > > I’m just forwarding the message: > > > > ``` > > <listitem> > > <para> > > Add slot synchronization skip information to pg_stat_replication_slots > > (Shlok Kyal) > > <ulink url="&commit_baseurl;76b78721c">§</ulink> > > <ulink url="&commit_baseurl;e68b6adad">§</ulink> > > <ulink url="&commit_baseurl;5db6a344a">§</ulink> > > </para> > > > > <para> > > The new columns are slotsync_skip_count, slotsync_last_skip, and > > slotsync_skip_reason. > > </para> > > </listitem> > > ``` > > > > The feature description is inaccurate: slotsync_skip_count and > > slotsync_last_skip belong to pg_stat_replication_slots, while > > slotsync_skip_reason belongs to pg_replication_slots. Maybe it could be > > reworded as: > > ``` > > Add slot synchronization skip information to pg_stat_replication_slots and > > pg_replication_slots (Shlok Kyal) > > ``` > > Yes, very good point. I missed that detail when merging the commit > items. I fixed it as you suggested, patch attached. > > -- > Bruce Momjian <[email protected]> https://momjian.us > EDB https://enterprisedb.com > > Do not let urgent matters crowd out time for investment in the future.
Did a review and found a few issues. Attached fixes. Regards Thom
diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml index f0911b86005..9aae934215a 100644 --- a/doc/src/sgml/release-19.sgml +++ b/doc/src/sgml/release-19.sgml @@ -77,7 +77,7 @@ Issue a warning after successful MD5 password authentication (Nathan Bossart) </para> <para> -The warning can be disabled via server variable md5_password_warnings. MD5 passwords were marked marked as deprecated in Postgres 18. +The warning can be disabled via server variable md5_password_warnings. MD5 passwords were marked as deprecated in Postgres 18. </para> </listitem> @@ -144,7 +144,7 @@ Change the default index opclasses for inet and cidr data types from btree_gist </para> <para> -The btree_gist inet/cidr opclasses are broken because they can exclude rows that should be returned. Pg_upgrade will fail to upgrade if btree_gist inet/cidr indexes exist in the old +The btree_gist inet/cidr opclasses are broken because they can exclude rows that should be returned. pg_upgrade will fail to upgrade if btree_gist inet/cidr indexes exist in the old server. </para> </listitem> @@ -328,7 +328,7 @@ Author: Richard Guo <[email protected]> <listitem> <para> -Allow NOT INs to be converted to more efficient ANTI JOINs when NULLs are not present (Richard Guo) +Allow NOT IN clauses to be converted to more efficient anti-joins when NULLs are not present (Richard Guo) <ulink url="&commit_baseurl;383eb21eb">§</ulink> </para> </listitem> @@ -700,7 +700,7 @@ Author: Nathan Bossart <[email protected]> <listitem> <para> -Improve COPY FROM performance for text and CSV output using SIMD CPU instructions (Nazir Bilal Yavuz, Shinya Kato) +Improve COPY FROM performance for text and CSV input using SIMD CPU instructions (Nazir Bilal Yavuz, Shinya Kato) <ulink url="&commit_baseurl;e0a3a3fd5">§</ulink> </para> </listitem> @@ -1210,7 +1210,7 @@ Author: Nathan Bossart <[email protected]> <listitem> <para> -Issue warnings when the wraparound of xid and multi-xids is less then 100 million (Nathan Bossart) +Issue warnings when the wraparound of xid and multi-xids is less than 100 million (Nathan Bossart) <ulink url="&commit_baseurl;48f11bfa0">§</ulink> </para> @@ -1588,7 +1588,7 @@ Add subscription option max_retention_duration to limit retain_dead_tuples reten </para> <para> -When the limit is reached, dead tuple retention until manually re-enabled or a new subscription is created. +When the limit is reached, dead tuple retention is disabled until manually re-enabled or a new subscription is created. </para> </listitem>
