Hi,
On Thu, 4 Jun 2026 at 22:03, Andres Freund <[email protected]> wrote:
>
> On 2026-06-04 09:02:13 -0700, Jacob Champion wrote:
> > On Thu, Jun 4, 2026 at 9:00 AM Andres Freund <[email protected]> wrote:
> > > > On the CPAN front, my first attempt tried to do too much, so I'm
> > > > testing a solution that just caches the CPAN sources directory. Should
> > > > have something shortly.
> > >
> > > I'm kinda inclined to push what we have and then add the cpan caching on
> > > top
> > > in subsequent commits?
> >
> > Right -- I don't think v1 should wait on CPAN optimization; I just
> > wanted to let you know the status.
>
> Pushed it now. Only a tiny change from the last version, Bilal suggested ove
> IM to remove the multi-threading argument from robocopy, for performance.
Thank you so much!
I realized one small problem today. When both Windows VS jobs fail, we
end up having two artifacts with the exactly same name. Here is a
small fix for it by adding '-slice-${slice_num}' to the end of the
artifact name.
--
Regards,
Nazir Bilal Yavuz
Microsoft
From 71fd65699a4239dd9e5d8446bdb04434f8629f14 Mon Sep 17 00:00:00 2001
From: Nazir Bilal Yavuz <[email protected]>
Date: Fri, 5 Jun 2026 17:44:40 +0300
Subject: [PATCH v1] ci: include matrix.slice in upload-artifact name
We use matrix in the Windows VS task so that we can use meson --slice
method and assign specific slice to each job. However, when the Windows
VS jobs fail, they upload artifacts with the same name. To fix that,
append matrix.slice when it is set.
Author: Nazir Bilal Yavuz <[email protected]>
Discussion: https://postgr.es/m/3ydjipcr7kbss57nvi67noplncqhesl5eyb6wgol4ccjxynspv%40yatlykpribmm
---
.github/workflows/pg-ci.yml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/pg-ci.yml b/.github/workflows/pg-ci.yml
index 8560e9389f6..db9bf1f99fe 100644
--- a/.github/workflows/pg-ci.yml
+++ b/.github/workflows/pg-ci.yml
@@ -373,7 +373,9 @@ jobs:
if: failure() && !cancelled()
uses: actions/upload-artifact@v7
with:
- name: logs-${{ github.job }}-${{ github.run_id }}-${{ github.run_attempt }}
+ # Include matrix.slice when set (e.g. windows-vs) so concurrent
+ # matrix entries don't try to upload artifacts with the same name.
+ name: logs-${{ github.job }}-${{ github.run_id }}-${{ github.run_attempt }}${{ matrix.slice && format('-slice-{0}', matrix.slice) || '' }}
path: |
**/*.log
**/*.diffs
--
2.47.3
