On Thu, Jun 18, 2026 at 10:11 PM Vitaly Davydov <[email protected]> wrote: > > Dear Fujii Masao, > > Thank you for the v5 patch. It looks good for me.
Thanks for the review! > I have no objections to commit the v5 patch without the tap-test. Once, it is > the bug fix, should we prepare the fix for other major branches? I'm ready to > prepare the patches based on the v5 version. Yes, it's really helpful if you prepare the patches for stable versions. > I looked at the tap test and found the reason why the test doesn't reproduce > the issue. The function adjust_conf in Cluster.pm changes the existing > parameter but doesn't add new new parameter to the configuration file if it is > missed. It doesn't report any errors as well. If to use the append_conf method > the test starts to reproduce the issue pretty stable, because the parameter is > actually added to the configuration file. > > One more note - in my original test I set autovacuum = off for all nodes, but > in modified 031 test autovacuum seems to be enabled. Disabling autovacuum may > make the test more stable. Thanks for the analysis! Regards, -- Fujii Masao
