On Sun Jul 26, 2026 at 4:38 PM UTC, Miłosz Bieniek wrote:
> Hi,
>
> On Sunday, 26 July 2026 at 18:05, Tristan Partin <[email protected]> wrote:
>
>> UUIDv6 is the same as UUIDv1 with some fields reordered. We already
>> supported UUIDv1, so let's add support for UUIDv6. Previously, calls to
>> uuid_extract_timestamp() would return NULL for UUIDv6 values.
>
> Makes sense, this would be the last missing piece in 
> uuid_extract_timestamp(). The code itself looks good.
>
>> Patch 2 only adds comments. I think the bit manipulation is worthy of
>> comments, but others may disagree.
>
> I think it's a good idea. Now it's much easier to understand what's going on 
> with these wild manipulations.

Thanks for the review.

-- 
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)


Reply via email to