On Fri, Jul 31, 2026 at 2:14 PM Peter Smith <[email protected]> wrote: > > A couple of comments for v24-0001 > > ====== > Commit message. > > 1. > Extend table exclusion support in publications to allow specific > tables to be excluded from schema-level publications using an > EXCEPT clause in CREATE PUBLICATION. > > Supported syntax: > CREATE PUBLICATION <pub> FOR TABLES IN SCHEMA s EXCEPT (TABLE t1,...); > > ~ > > 1a. > Change /<pub>/pub/ > > ~ > > 1b. > Now that you are combining more patches, this commit message seemed a > bit light on details. > > You might say include things like: > > NOTES > - Conflicting or redundant EXCEPT clauses are not allowed > - EXCEPT clause tables must come from the associate schema > - psql describe commands are updated handle tables excluded from schemas > - Excluding partitions in not allowed > - Excluding a partition root excludes the entire partition tree, even > tables in different schemas > - etc. >
Update the commit message for patch 001 with more details. > ====== > src/backend/utils/cache/relcache.c > > RelationBuildPublicationDesc: > > 1. > + /* Drop the publications that exclude this relation. */ > + if (exceptpuboids != NIL) > + puboids = list_difference_oid(puboids, exceptpuboids); > + > > AFAIK, there is no DROP PUBLICATION in this logic. > > Instead of "Drop", how about "Ignore" or "Skip" to remove any ambiguity. > Updated. -- Thanks, Nisha
