> The failure is triggered at the end of perform_base_backup() when > total_checksum_failures equals 1, > via ereport(ERROR, errcode(XX001)). > However, pg_stat_database.checksum_failures is not updated at all.
This seems like a separate issue existing for much longer, I'll submit a separate patch about it. > Judging by the current test cases,, > pg_stat_database.checksum_failures appears to offer no detection capability > beyond what ok($backup->finish) already provides. I improved the tests a bit, while also adding the 32m shared buffers change to 010. I kept this as a separate commit for easier review.
v5-0003-Test-improvements-based-on-review-comments.patch
Description: Binary data
v5-0001-basebackup-do-not-verify-checksums-on-pages-from-.patch
Description: Binary data
v5-0002-Review-hackery.patch
Description: Binary data
