> On Sep 5, 2026, at 21:11, shihao zhong <[email protected]> wrote:
> 
> Hi hackers,
> 
> The introduction to the database object size functions in
> func-admin.sgml says that passing an OID that does not represent an
> existing object returns NULL.  That is true for the relation size
> functions, but pg_database_size() and pg_tablespace_size() raise an
> error for a nonexistent OID instead.  The attached patch documents the
> exception.
> 
> Thanks,
> Shihao
> <0001-doc-note-that-pg_database_size-and-pg_tablespace_siz.patch>


The change overall looks good to me. One nitpick:
```
+    functions, <literal>NULL</literal> is returned, except by
```

“Except by” sounds uncommon, is “expect for” better?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






Reply via email to