Hi,

I reviewed and tested the v2 patch.
I first verified the existing behavior with a nonexistent OID:
-pg_database_size(999999) returns an error saying the database does not exist.
-pg_tablespace_size(999999) returns an error saying the tablespace
does not exist.

I then applied the v2 patch. It applied cleanly, and git diff --check
reported no issues.
After applying the patch, I repeated the same tests and confirmed that
the behavior remains unchanged. I also tested valid database and
tablespace OIDs, and both returned the expected size values.

>From my testing, the patch correctly documents the existing exception
without changing the runtime behavior.
The v2 patch looks good to me.

Thanks,
solai


Reply via email to