On Thu, Sep 10, 2026 at 2:31 PM Melanie Plageman <[email protected]> wrote: > > An adversarial LLM review of this patch series found that I call > visibilitymap_pin() after taking a cleanup lock on the heap page in > the on-access pruning path -- which is not good. Here is a small patch > to fix that. Doing it before we're sure we can get the cleanup lock > could occasionally lead to an unneeded pin, but such situations should > be uncommon.
It also reported that since d96f87332b3 the FSM will be less up to date on the standby since COPY FREEZE criteria for updating the FSM is if (action == BLK_NEEDS_REDO && freespace < BLCKSZ / 5) and the old VM record replay code had no such freespace check. I'll post a patch to fix that tomorrow. The fix is pretty simple: just update the FSM if the heap multi insert record sets the VM. - Melanie
