On Sun, Sep 13, 2026 at 10:22 PM Chao Li <[email protected]> wrote: > > > On Sep 12, 2026, at 04:08, Melanie Plageman <[email protected]> > > wrote: > > > <v1-0001-Avoid-setting-pd_prune_xid-when-inserting-frozen-.patch> > > The change looks correct to me.
Thanks for the review. I've pushed this. > One nit: perhaps we could take this opportunity to do a small refactoring, > such as declaring i in the for loop and moving tbuf, htup, and newlen into > the loop. This would reduce their scope and may improve readability. > > For your convenience, I made those small changes in v2. If you don’t like > them, feel free to discard v2. This was a good suggestion, but I prefer to keep bug fixes that get backpatched as minimal as possible. Part of it is making it as understandable as possible but also every single code change we make can accidentally introduce bugs (I know these wouldn't) and the less we can do that in backbranches the better. I would be happy to do this kind of cleanup (reducing variable scope helps prevent bugs of course) as part of a larger commit to master only, though. Speaking of which, I noticed while working on this that 8e03eb92e9a, which reverted setting the VM for single inserts, also made it so inserting frozen rows into an already all-visible page cleared the VM and PD_ALL_VISIBLE. I haven't studied it closely, but I think this might just be an oversight and there is no reason to clear all-visible when inserting only a frozen row. I'm not sure I would backpatch this, but it seems reasonable to fix on master after some careful thought. - Melanie
