Hi,

On Friday, September 11, 2026 2:01 PM Nisha Moond <[email protected]> 
wrote:
> 
> Thanks for sharing the patch. It looks good to me. I’ve updated the attached
> patch accordingly.

The fix looks mostly good to me. The only nit is that we could avoid introducing
a new Boolean flag by writing it like this:

RelationBuildPublicationDesc()
..
    if (relation->rd_rel->relispartition)
        ancestors = get_partition_ancestors(relid);

    if (ancestors)
    {
        Oid         last_ancestor_relid;

        last_ancestor_relid = llast_oid(ancestors);
...

Best Regards,
Zhijie Hou

Reply via email to