vignesh C <[email protected]> wrote: > Please have a look at the discussion regarding the commit in [1] > thread. If you still feel that it needs further discussion, we can > continue discussing your suggestion in the thread at [2], as it is not > directly related to the topic of this current thread.
Thanks, I had not seen [2]. Peter raised the nested quotes there on May 11 with the same kind of example, and you considered them acceptable, citing REFRESH MATERIALIZED VIEW CONCURRENTLY. So 0002 is not a new finding, and I withdraw it. I also need to correct a number I gave. I wrote that 55 errmsg() calls in src/backend use "\"%s.%s\"" against 3 that put a quoted qualified name inside quotes. My search missed calls whose arguments are on later lines. Reading each errmsg/errdetail/errhint call in full on REL_19_STABLE, it is 70 against 2: matview.c (the case you cited) and the EXCEPT message in pg_publication.c. > Thanks, Manu, for the patches. I think it would be better to start a > new thread to discuss this and the other functions listed by Hou-san > at [1]. Agreed, and Peter's list in [2] already goes well beyond these four messages, so I will leave 0001 out of this thread. Regards, Manu El mié, 16 sept 2026 a las 13:58, vignesh C (<[email protected]>) escribió: > > On Wed, 16 Sept 2026 at 14:26, vignesh C <[email protected]> wrote: > > > > On Wed, 16 Sept 2026 at 13:57, Chao Li <[email protected]> wrote: > > > > > > I don’t think the fix would add much complexity, please see the attached > > > diff I tried. This error message is shown to users, so I think improving > > > it is worthwhile. > > > > Agreed. I had initially thought the additional code complexity was not > > worthwhile. Since this is a user-facing error message, I agree that > > making it more specific is worthwhile. Thanks, I have merged the > > changes. > > The attached v5 version patch has the changes for the same. > > While reviewing the patch further, I noticed that the Assert in > get_object_address_publication_rel() can be placed immediately after > the variable declarations, rather than after the subsequent checks. > The attached v6 patch includes this change. > > Regards, > Vignesh
