> > track_cost_delay_timing gates delay timing reporting elsewhere, so we > > should not > > deviate from that. If the GUC is off by then, we should not accumulate > > any timing > > anyhow, even if parallel_vacuum_worker_delay_ns > 0 > > IIUC the remaining parallel_vacuum_worker_delay_ns was accumulated > when the track_cost_delay_timing was enabled. Shouldn't we report it > as well?
We could swap ``` /* Report any remaining cost-based vacuum delay time */ if (track_cost_delay_timing) ``` with ``` /* Report any remaining cost-based vacuum delay time */ if (parallel_vacuum_worker_delay_ns) ``` but I did not think that made sense. When we get to the point of reporting the remaining time, and the track_cost_delay_timing is disabled, then I don't think we should report anything. -- Sami
