Hi, I noticed that pg_walsummary can still print limit lines when --quiet is specified. This happens with summaries containing relation creation or truncation, for example:
$ pg_walsummary --quiet example.summary
TS 1663, DB 5, REL 16387, FORK main: limit 0
If I understand correctly, --quiet should suppress
all output except errors.
In dump_one_relation(), the limit line is printed before the existing
quiet check. The attached patch adds a quiet check to that output while
preserving parsing and error detection.
The patch also adds TAP coverage for -q and --quiet and checks that a
truncated input file is still rejected. The pg_walsummary tests pass
with the patch.
Feedback would be appreciated.
Koshi Shibagaki
FUJITSU LIMITED
https://www.fujitsu.com/
v1-0001-pg_walsummary-quiet.patch
Description: v1-0001-pg_walsummary-quiet.patch
