On Mon, Oct 5, 2026 at 12:23 PM Koshi Shibagaki (Fujitsu)
<[email protected]> wrote:
> Feedback would be appreciated.
Thanks for the patch!
+for my $option ('-q', '--quiet')
Testing both forms with the same input and expected output seems a bit
overkill for this fix, since both set the same flag. Isn't testing just
one of them be sufficient?
+# Quiet mode must still parse every file, including the final checksum.
Isn't this primarily adding test coverage for existing quiet-mode behavior,
rather than testing the bug being fixed? If so, it might be better to leave
this out of the bug-fix patch intended for backpatching. Thought?
Also, this fix should be backpatched to v17, where pg_walsummary was
introduced?
Regards,
--
Fujii Masao
