On Sat, Oct 3, 2026 at 8:35 PM Alvaro Herrera <[email protected]> wrote: > > On 2026-Sep-30, Radim Marek wrote: > > > Ok, I can't add much to the implementation discussion, but I can confirm > > the patch resolves both use cases I reported. > > Thank you, I have pushed it to both branches after adjusting the test > case a bit more.
Thanks for working on this!
'repack_decode',
+ 'repack_dropped',
'repack_missingval',
repack_dropped isolation test should also be listed in Makefile, in
addition to meson.build?
+teardown {
+ DROP TABLE repack_dropped;
+ DROP FUNCTION repack_dropped_f;
+}
Should teardown also drop the injection_points extension created by
setup, as the other tests that create the injection_points extension
do?
This missing DROP seems harmless with the current Meson test order, since
repack_missingval runs next, uses CREATE EXTENSION IF NOT EXISTS, and
then drops the extension. However, that seems fragile.
The attached patch fixes both issues.
Regards,
--
Fujii Masao
v1-0001-Fix-registration-and-cleanup-of-repack_dropped-is.patch
Description: Binary data
