On Mon, Oct 05, 2026 at 09:20:27AM +0000, Bertrand Drouvot wrote: > The comment above segment_close() says that ws_file shall be set to a negative > number, while both this callback and XLogReaderFree() check for -1. I wonder > if > they should test >= 0 instead?
Probably just checking for negative is fine here, yes. > Worth mentioning that this is intended for descriptors not managed by another > cleanup mechanism, such as those returned by BasicOpenFile()? Otherwise, > using > it with OpenTransientFile() could result in segment_close() being called with > a > stale descriptor. Hmm. How would you reword this comment? I am also interested in hearing from Bharath about the latest version of the patch posted. -- Michael
signature.asc
Description: PGP signature
