On Wed, Oct 07, 2026 at 11:34:40AM -0700, Bharath Rupireddy wrote: > I addressed Bertrand's review comments. I renamed the reset callback > to keep it generic (closing the open WAL segment file is one cleanup > that could be done here but it could be extended for any other > resources held by XLogReader). I adjusted the comments. I like the > comment around segment_close on not throwing errors, although the core > callbacks inherently follow that (they ignore errors from close()), > it's good to have it. I ran pgindent and tests. I wrote the commit > message.
Sounds fine to me code-wise. Applied on HEAD after more review and a few tweaks. -- Michael
signature.asc
Description: PGP signature
