On Tue, Oct 6, 2026 at 8:41 PM Tom Lane <[email protected]> wrote: > If you like, but my experience is that getting this right is pretty > painful if you don't have a cross-version-upgrade-testing BF animal > to experiment on. I do ...
Something like the attached seems like it'd do the job. But, yeah, realistically, the hard part is proper testing and validation, which I lack the ability to do myself. -- Peter Geoghegan
From be347949c517fcd151726f843c82b3b8fd8c5c12 Mon Sep 17 00:00:00 2001 From: Peter Geoghegan <[email protected]> Date: Tue, 6 Oct 2026 20:11:37 -0400 Subject: [PATCH] Fix XversionUpgrade allequalimage failures. --- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm index 04844298a..a2d690131 100644 --- a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm +++ b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm @@ -198,6 +198,20 @@ sub adjust_database_contents 'drop operator if exists !=- (bigint,NONE)', 'drop operator if exists #@%# (bigint,NONE)'); + # v13 bpchar_ops indexes claim deduplication is safe; amcheck + # complains about that after upgrade, so drop them + _add_st( + $result, 'regression', + 'drop index if exists public.room_rno', + 'drop index if exists public.wslot_name', + 'drop index if exists public.pslot_name', + 'drop index if exists public.pline_name', + 'drop index if exists public.hub_name', + 'drop index if exists public.hslot_name', + 'drop index if exists public.hslot_hubname', + 'drop index if exists public.iface_name', + 'drop index if exists public.phone_name'); + # get rid of dblink's dependencies on regress.so if ($dbnames{'contrib_regression_dblink'}) { -- 2.55.0
