Hi all

On 2026/10/09 11:34, Hayato Kuroda (Fujitsu) wrote:

> Indeed, PSA the new version.
> Also, I adjusted the order of the initialization of DecodingWorker to align 
> with
> the location of attributes.
I don't have any objections to the fixes and am learning from the fixes.

But let me add two minor comments.
Do we plan to commit the test codes as well?
While I was running test codes, I noticed
src/test/subscription/meson.build lacks
't/039_streaming_parallel_apply_error_context.pl line. Without this
line, meson test don't execute this test.

> +      'enable_injection_points': 'yes',

The other minor thing is, I believe we can remove this line from
injection_points/meson.build since
the repack test code does not check this environment value and without
this I was able to execute this test. Moreover, the tests under
injection_points directory just finish if injection_points is not
configured according to meson.build.

Regards,
Takeshi Ideriha







Reply via email to