Hi Ideriha-san, Thanks for the review. PSA v4 patch set.
> I don't have any objections to the fixes and am learning from the fixes. > > But let me add two minor comments. > Do we plan to commit the test codes as well? > While I was running test codes, I noticed > src/test/subscription/meson.build lacks > 't/039_streaming_parallel_apply_error_context.pl line. Without this > line, meson test don't execute this test. I think the current code won't be included to core, thus we do not take care the shape of meson.build (I have tested with fixing it locally). But it might be better to add for the cfbot. Done. Also, I found the test sometimes could not launch the parallel apply worker because of the race condition with the table synchronization. I set to copy_data = false instead. > > + 'enable_injection_points': 'yes', > > The other minor thing is, I believe we can remove this line from > injection_points/meson.build since > the repack test code does not check this environment value and without > this I was able to execute this test. Moreover, the tests under > injection_points directory just finish if injection_points is not > configured according to meson.build. Indeed, removed. I have not checked well due to the above reason. Best regards, Hayato Kuroda FUJITSU LIMITED
v4-0001-Test-to-reproduce-parallel-apply-error-context-is.patch
Description: v4-0001-Test-to-reproduce-parallel-apply-error-context-is.patch
v4-0002-Preserve-an-error-context-before-entering-an-appl.patch
Description: v4-0002-Preserve-an-error-context-before-entering-an-appl.patch
v4-0003-Reproduce-the-mixture-of-the-error-context-by-REP.patch
Description: v4-0003-Reproduce-the-mixture-of-the-error-context-by-REP.patch
v4-0004-Preserve-an-error-context-before-launching-a-repa.patch
Description: v4-0004-Preserve-an-error-context-before-launching-a-repa.patch
