> On Oct 28, 2026, at 19:45, Fujii Masao <[email protected]> wrote:
>
> On Wed, Oct 28, 2026 at 7:15 PM Ashutosh Sharma <[email protected]> wrote:
>> Thanks for the review and suggestions. I agree that we can verify
>> these changes by adding log checks to the existing TAP test for
>> two-phase transactions. I’ve done that in the attached patch, which is
>> based on the changes suggested in your earlier patch. Please take a
>> look and let me know if you have any other comments.
>
> Thanks for updating the patch!
>
> - ereport(LOG,
> + ereport(DEBUG1,
>
> Do we want to keep this debug message translatable? If not, we could
> simplify this to elog().
Ah, that’s a good point.
>
> Also, DEBUG2 might be more consistent with per-transaction messages
> in PrepareRedoAdd() and PrepareRedoRemoveFull()? Those use elog(DEBUG2, ...).
> This would also avoid flooding the log at DEBUG1.
>
+1
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
